Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): correct content description component #12538

Merged
merged 3 commits into from Aug 19, 2021

Conversation

garymathews
Copy link
Contributor

  • Correct the component that content description is set on for TextField and ImageView
TEST CASE
  • Check content description via TalkBack service or Appium.
const win = Ti.UI.createWindow({
	layout: 'vertical',
	backgroundColor: 'gray'
});
const txt = Ti.UI.createTextField({
	top: 20,
	value: 'Some random text.',
	accessibilityLabel: 'RandomText'
});
const img = Ti.UI.createImageView({
	top: 20,
	image: 'https://garymathews.com/droid.gif',
	accessibilityLabel: 'DroidImage'
});

win.add([ txt, img ]);
win.open();

JIRA Ticket

@garymathews garymathews added this to the 10.1.0 milestone Mar 10, 2021
@build build requested a review from a team March 10, 2021 17:28
@build
Copy link
Contributor

build commented Mar 10, 2021

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 2 tests have failed There are 2 tests failing and 955 skipped out of 16866 total tests.
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.View"after all" hook for "rgba fallback" (5.0.2)20.451
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.View"after each" hook for "getOrCreateView() should always return a View" (5.0.2)10.378
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against f25aaf5

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Pass. content-desc now correctly shows for ImageView and TextField

@ewanharris ewanharris merged commit db1a83a into tidev:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants