Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update liveview to 1.5.5 #12562

Merged
merged 1 commit into from Mar 16, 2021
Merged

chore(deps): update liveview to 1.5.5 #12562

merged 1 commit into from Mar 16, 2021

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy sgtcoolguy commented Mar 12, 2021 •
edited

JIRA: https://jira.appcelerator.org/browse/TIMOB-28382

Description:

What it says on the tin

Note that due to package-lock.json lock file version change, this needs to be manually back ported to 10_0_X

@build build added this to the 10.1.0 milestone Mar 12, 2021
@build
Copy link
Contributor

build commented Mar 12, 2021 •
edited

Fails
🚫 Tests have failed, see below for more information.
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 737 skipped out of 12390 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.View"after all" hook for "rgba fallback" (5.0.2)10.551
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against f56dd5f

@sgtcoolguy sgtcoolguy mentioned this pull request Mar 12, 2021
Closed
@sgtcoolguy
Copy link
Contributor Author

Duplicates #12574

@ssekhri
Copy link

ssekhri commented Mar 15, 2021

FR Passed.
Verified on:
Mac OS: 10.15.4
SDK: 10.1.0.v20210312124659
Liveview: 1.5.5
Appc CLI: 8.1.1
JDK: 11.0.6
Node: 12.16.1
Studio: 6.0.0.202005141803
Xcode: 12.4
iOs simulator 11.4

@sgtcoolguy sgtcoolguy merged commit 5b1d281 into tidev:master Mar 16, 2021
@sgtcoolguy sgtcoolguy deleted the liveview-1.5.5 branch March 16, 2021 14:08
@sgtcoolguy sgtcoolguy added the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Mar 16, 2021
@sgtcoolguy sgtcoolguy mentioned this pull request Mar 16, 2021
Closed
@build build mentioned this pull request Mar 16, 2021
Merged
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
bug cli 📟 in-qe-testing 🕵
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgtcoolguy @build @ssekhri @ewanharris