Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ios): use CLGeocoder APIs to reverse geocode and forward geocode #12581

Merged
merged 7 commits into from Mar 18, 2021

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway changed the title chore(ios): use natuve APIs to reverse geocode and forward geocode chore(ios): use CLGeocoder APIs to reverse geocode and forward geocode Mar 15, 2021
@build build added this to the 10.1.0 milestone Mar 15, 2021
@build build requested a review from a team March 15, 2021 22:03
@build
Copy link
Contributor

build commented Mar 15, 2021

Fails
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

Warnings
⚠️

tests/Resources/ti.geolocation.test.js#L364 - tests/Resources/ti.geolocation.test.js line 364 – Expected catch() or return (promise/catch-or-return)

⚠️

tests/Resources/ti.geolocation.test.js#L530 - tests/Resources/ti.geolocation.test.js line 530 – Each then() should return a value or throw (promise/always-return)

Messages
📖

✅ All tests are passing
Nice one! All 11016 tests are passing.
(There are 733 skipped tests not included in that total)

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 👍 Hey!, You deleted more code than you added. That's awesome!

Generated by 🚫 dangerJS against 601ea70

@ewanharris ewanharris added backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge backport 9_3_X and removed 10_0_X backport failed labels Mar 16, 2021
iphone/Classes/GeolocationModule.m Outdated Show resolved Hide resolved
@build build added the docs label Mar 16, 2021
@sgtcoolguy
Copy link
Contributor

For reference, the conventional commit should be more like refactor(ios): use CLGeocoder APIs to reverse geocode and forward geocode since this is intended as an internal refactoring and not a bug fix, new feature/improvement - and definitely isn't build or chore. chore is typically a catch-all for things, but a better prefix should always be preferred first. I think we're just used to seeing it from dependabot/greenkeeper for updating dependencies so everyone just defaults to it. But in fact, even dependabot now uses build to tag dependency updates.

@sgtcoolguy sgtcoolguy merged commit e162d67 into tidev:master Mar 18, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Mar 18, 2021
@build
Copy link
Contributor

build commented Mar 18, 2021

The backport to 9_3_X failed:

The process 'git' failed with exit code 128

Check the run for full details
To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Check out the target branch
git checkout 9_3_X
# Make sure it's up to date
git pull
# Check out your branch
git checkout -b backport-12581-to-9_3_X
# Apply the commits from the PR
curl -s https://github.com/appcelerator/titanium_mobile/commit/deb47ead203c09295b955ab7d4426f34a2c0a5c5.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/9bb4a2559c5ff398caa028c9411164cf25ca7377.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/6758fd80e9c65610d270aa8806ca6bbc33ee6a3f.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/a9b9cf9ab663b9415f7279c2ce9ff6c239f38848.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/a29e4fb5ad2e903a4b4df696ccc27f0835dd6d10.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/a4e0a51fc84837d3d487596c3b753592b9e25d52.patch | git am -3 --ignore-whitespace
# Push it to GitHub
git push --set-upstream origin backport-12581-to-9_3_X

Then, create a pull request where the base branch is 9_3_X and the compare/head branch is backport-12581-to-9_3_X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants