New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): fixed setSelection issue of textfield #12654
Conversation
win.addEventListener('postlayout', function listener () { | ||
win.removeEventListener('postlayout', listener); | ||
textField.setSelection(0, 5); | ||
setTimeout(function (e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ tests/Resources/ti.ui.textfield.test.js line 415 – 'e' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the e
argument please? That way we won't get this lint warnings in all of our PRs. 😛
Tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a FR standpoint looks good, tested using the test cases from https://jira.appcelerator.org/browse/TIMOB-28404
Test Environment
MacOS Big Sur: 11.1 Beta 1
Xcode: 12.2 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
iphone 8 14.4
https://jira.appcelerator.org/browse/TIMOB-28404