Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): fixed setSelection issue of textfield #12654

Merged
merged 4 commits into from Mar 26, 2021

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway commented Mar 24, 2021

@vijaysingh-axway vijaysingh-axway added backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge bug labels Mar 24, 2021
@build build added this to the 10.1.0 milestone Mar 24, 2021
@build build requested review from a team March 24, 2021 20:08
win.addEventListener('postlayout', function listener () {
win.removeEventListener('postlayout', listener);
textField.setSelection(0, 5);
setTimeout(function (e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ tests/Resources/ti.ui.textfield.test.js line 415 – 'e' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the e argument please? That way we won't get this lint warnings in all of our PRs. 😛

@build
Copy link
Contributor

build commented Mar 24, 2021

Fails
🚫 Tests have failed, see below for more information.
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 6 tests have failed There are 6 tests failing and 735 skipped out of 11756 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.Android.ProgressIndicatordialog indeterminant - show in different windows (5.0.2)5.133
Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.NavigationWindowbasic open/close navigation (5.0.2)10.045
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.TextArea.properties.focused (5.0.2)5.01
Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.TextField.properties.focused (5.0.2)2.263
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.View"after each" hook for "getOrCreateView() should always return a View" (5.0.2)12.913
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.ipad.Titanium.Analytics.properties.optedOut can be assigned a Boolean value (14.4.0)24.954
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
run@file:///ti.main.js:8744:22
processImmediateQueue@file:///ti.main.js:8807:18
drainQueues@file:///ti.main.js:8784:52

Generated by 🚫 dangerJS against 8bff842

@ssjsamir ssjsamir self-requested a review March 26, 2021 14:46
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a FR standpoint looks good, tested using the test cases from https://jira.appcelerator.org/browse/TIMOB-28404

Test Environment

MacOS Big Sur: 11.1 Beta 1
Xcode: 12.2 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
iphone 8 14.4

@sgtcoolguy sgtcoolguy merged commit 4316f54 into tidev:master Mar 26, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants