New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add property "enableCopy" to TextField/TextArea #12657
Conversation
Tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Android CR: PASS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS changes looks good!
@jquick-axway , The changes does not seem to be working on Android 5.1 API 22. |
@lokeshchdhry, are you sure you don't see a "copy" option in the top toolbar? The popup menu won't show the "copy" option for me either on Android 5.x, but the same is true in Google's own apps like Messaging. Basically, we can't control where the Android OS puts these options (in a popup or toolbar), but they are there for me. |
@jquick-axway , Alright makes sense. I see the copy option in the tool bar. Was not sure if popup should be an option. |
FR Passed. |
The backport to
Check the run for full details # Fetch latest updates from GitHub
git fetch
# Check out the target branch
git checkout 10_0_X
# Make sure it's up to date
git pull
# Check out your branch
git checkout -b backport-12657-to-10_0_X
# Apply the commits from the PR
curl -s https://github.com/appcelerator/titanium_mobile/commit/63bd9103714be6cb52468cc6fda71a1a9ab4452b.patch | git am -3 --ignore-whitespace
# Push it to GitHub
git push --set-upstream origin backport-12657-to-10_0_X Then, create a pull request where the |
JIRA:
https://jira.appcelerator.org/browse/TIMOB-25705
Summary:
TextField
/TextArea
.true
.false
will do the following...copy
,cut
,share
Command+C
andCommand+X
keyboard operations.Note:
On Android, we can't remove the
copy
andcut
options from the virtual keyboard's "Text Editing" section or the landscape fullscreen context menu... but we can block the copy/cut actions from working.TextField Test:
(Run below test on iOS, Android 5.0, and Android 11.)
TextFieldDisableCopyTest.js
attached to TIMOB-25705.TextArea Test:
(Run below test on iOS, Android 5.0, and Android 11.)
TextAreaDisableCopyTest.js
attached to TIMOB-25705.Bonus Test:
There is a
TextFieldKeyboardAdvancedTest.js
script attached to TIMOB-25705 which makes it easy to test various combinations of text field options for ad-hoc testing.