Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 10_0_X] fix(ios): fixed setSelection issue of textfield #12666

Merged
merged 3 commits into from Mar 26, 2021

Conversation

build
Copy link
Contributor

@build build commented Mar 26, 2021

Backport of #12654.
See that PR for full details.

@build build added this to the 10.0.0 milestone Mar 26, 2021
@build build requested review from a team March 26, 2021 15:58
win.addEventListener('postlayout', function listener () {
win.removeEventListener('postlayout', listener);
textField.setSelection(0, 5);
setTimeout(function (e) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ tests/Resources/ti.ui.textfield.test.js line 415 – 'e' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

@build
Copy link
Contributor Author

build commented Mar 26, 2021

Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 11064 tests are passing.
(There are 678 skipped tests not included in that total)

Generated by 🚫 dangerJS against 881e039

@sgtcoolguy sgtcoolguy merged commit fff45b2 into tidev:10_0_X Mar 26, 2021
@sgtcoolguy sgtcoolguy deleted the backport-12654-to-10_0_X branch March 26, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants