New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android): improve TabGroup material color and ripple handling #12679
Conversation
Tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
FR Passed. |
The backport to
Check the run for full details # Fetch latest updates from GitHub
git fetch
# Check out the target branch
git checkout 10_0_X
# Make sure it's up to date
git pull
# Check out your branch
git checkout -b backport-12679-to-10_0_X
# Apply the commits from the PR
curl -s https://github.com/appcelerator/titanium_mobile/commit/9481df6a3fc8584aff4a6932fb1cfdf6ada56057.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/524d5fb233d938625ae4c31e86ac632aeed37335.patch | git am -3 --ignore-whitespace
# Push it to GitHub
git push --set-upstream origin backport-12679-to-10_0_X Then, create a pull request where the |
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28301
Summary:
activeTintColor
as ripple color if defined.colorPrimary
if not defined, which is what it was defaulting to before.TabGroup
/Tab
:Ti.UI.TabGroup.tabsBackgroundSelectedColor
Ti.UI.Tab.backgroundFocusedColor
TabGroup Default Theme Test:
app.js
and build and run on Android.// style: OS_ANDROID ? Ti.UI.Android.TABS_STYLE_BOTTOM_NAVIGATION : null,
TabGroup Shared Custom Colors Test:
app.js
and build and run on Android.// style: OS_ANDROID ? Ti.UI.Android.TABS_STYLE_BOTTOM_NAVIGATION : null,
TabGroup Custom Tab Colors Test:
app.js
and build and run on Android.// style: OS_ANDROID ? Ti.UI.Android.TABS_STYLE_BOTTOM_NAVIGATION : null,