New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): use weak instead of assign in properties for Objects #12706
Conversation
Tests:
|
Could this be the cause of https://jira.appcelerator.org/browse/TIMOB-28296 ? There we have pretty consistent crashes with Do we need to make the |
It doesn't look we have to make |
https://jira.appcelerator.org/browse/TIMOB-28413
https://jira.appcelerator.org/browse/TIMOB-28344
In general 'assign' is used for primitive data types and 'weak' is used for objects. If object is deallocated from anywhere, any 'weak' reference to that object is set nil. In assign, if object is deallocated you will still have a pointer to it's memory (which is garbage now)