New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): setting tab properties before open event crashes as of 10.0.0 #12717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquick-axway
added
android
bug
backport 10_2_X
when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge
labels
Apr 13, 2021
Tests:
|
garymathews
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
sgtcoolguy
approved these changes
Apr 13, 2021
ssjsamir
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed, tested using the instructions mentioned in the description
Test Environment
MacOS Big Sur: 11.1 Beta 1
Xcode: 12.2 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
Android API 29 Nexus 5X emulator
build
removed
the
backport 10_2_X
when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge
label
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28418
Summary:
TabGroup
's tab property after creation but before the "open" event crashes as of 10.0.0.TabProxy.onPropertyChanged()
callingTabGroupProxy.getOrCreateView()
method. It can't create tab group's view until activity has been opened. (I'm not sure why it didn't crash before 10.0.0.)activeTab
property was not set as of 10.0.0.No valid tab provided when setting active tab.
Cannot activate tab not in this group.
Test:
TabGroupChangeBeforeOpenTest.js
attached to TIMOB-28418 as theapp.js
.Tab 1
andTab 2
tab titles with icons.1
and tab 2's badge number is2
.No valid tab provided when setting active tab.