Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 10_0_X] fix(ios): report script source urls using full file: uris #12727

Merged
merged 1 commit into from Apr 16, 2021

Conversation

build
Copy link
Contributor

@build build commented Apr 15, 2021

Backport of #12725.
See that PR for full details.

make the full file:// uri based on app resource path

Fixes TIMOB-28422
@build
Copy link
Contributor Author

build commented Apr 15, 2021

Fails
🚫 Tests have failed, see below for more information.
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 6 tests have failed There are 6 tests failing and 459 skipped out of 8393 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Geolocation.methods#reverseGeocoder() works via Promise return value (5.0.2)2.013
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.Geolocation.methods#reverseGeocoder() works via function callback (5.0.2)5.009
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:645:32)
android.emulator.Titanium.Geolocation.methods#forwardGeocoder() works via Promise return value (5.0.2)5.007
Error: done() invoked with non-Error: {"source":{"accuracy":1,"locationServicesEnabled":true,"hasCompass":true,"lastGeolocation":"{\"latitude\":37.4219983,\"longitude\":-122.084,\"altitude\":5,\"accuracy\":20,\"heading\":90,\"speed\":0,\"timestamp\":1618525130000}","apiName":"Ti.Geolocation","bubbleParent":true,"__propertiesDefined__":true},"code":-1,"success":false}
at /ti.geolocation.test.js:610:10
android.emulator.Titanium.Geolocation.methods#forwardGeocoder() works via callback argument (5.0.2)5.011
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:585:32)
android.emulator.Titanium.UI.View"after all" hook for "rgba fallback" (5.0.2)20.546
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.View"after each" hook for "getOrCreateView() should always return a View" (5.0.2)10.539
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against eb85013

@sgtcoolguy sgtcoolguy merged commit 0099dc3 into tidev:10_0_X Apr 16, 2021
@sgtcoolguy sgtcoolguy deleted the backport-12725-to-10_0_X branch April 16, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants