Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): normalize encrypted asset paths #12733

Merged
merged 1 commit into from Apr 21, 2021

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Apr 20, 2021

  • Normalize encrypted asset paths
  • Prevent length on undefined object error when no devices are found
NOTES
  • cache.json already normalizes paths
  • index.json used for require also normalizes paths

JIRA Ticket

@garymathews garymathews added android bug no tests backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels Apr 20, 2021
@garymathews garymathews added this to the 10.1.0 milestone Apr 20, 2021
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@build
Copy link
Contributor

build commented Apr 20, 2021

Fails
🚫 Tests have failed, see below for more information.
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

Messages
📖 ❌ 4 tests have failed There are 4 tests failing and 697 skipped out of 13137 total tests.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Network.HTTPClientcallbackTestForPOSTMethod (5.0.2)0.003
Error: Uncaught Uncaught RangeError: Maximum call stack size exceeded
android.emulator.Titanium.Network.HTTPClientcallbackTestForGETMethod (5.0.2)30.972
Error: onreadystatechange done fired before 100% progress
at HTTPClient.xhr.onreadystatechange (/ti.network.httpclient.test.js:464:8)
android.emulator.Titanium.UI.View"after all" hook for "rgba fallback" (5.0.2)20.471
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.View"after each" hook for "getOrCreateView() should always return a View" (5.0.2)10.459
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against dc8d7fc

@ssjsamir ssjsamir self-requested a review April 21, 2021 14:42
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed, able to build to android device without an error.

Test environment

Operating System
  Name                        = Microsoft Windows 10 Pro
  Version                     = 10.0.18363
  Architecture                = 64bit
  # CPUs                      = 16
  Memory                      = 63.9GB

Node.js
  Node.js Version             = 12.16.1
  npm Version                 = 6.13.4

Appcelerator CLI
  Installer                   = 6.0.0-1
  Core Package                = 9.0.0-9

Titanium CLI
  CLI Version                 = 5.3.0
  node-appc Version           = 1.1.2

@sgtcoolguy sgtcoolguy merged commit 402eaf8 into tidev:master Apr 21, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants