Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): image asset suffix handling #12749

Merged
merged 3 commits into from May 3, 2021
Merged

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Apr 26, 2021

  • Amend incorrect match group for idiom
TEST CASE
  • Rename any iOS image asset to test~iphone.png
  • Project should build successfully

JIRA Ticket

@garymathews garymathews added ios bug no tests backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels Apr 26, 2021
@garymathews garymathews added this to the 10.1.0 milestone Apr 26, 2021
@build
Copy link
Contributor

build commented Apr 26, 2021

Fails
🚫 Tests have failed, see below for more information.
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 13 tests have failed There are 13 tests failing and 682 skipped out of 12522 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Geolocation.methods#reverseGeocoder() works via Promise return value (5.0.2)2.099
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.Geolocation.methods#reverseGeocoder() works via function callback (5.0.2)5.039
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:645:32)
android.emulator.Titanium.Geolocation.methods#forwardGeocoder() works via Promise return value (5.0.2)5.007
Error: done() invoked with non-Error: {"source":{"accuracy":1,"locationServicesEnabled":true,"hasCompass":true,"lastGeolocation":"{\"latitude\":37.4219983,\"longitude\":-122.084,\"altitude\":5,\"accuracy\":20,\"heading\":0,\"speed\":0,\"timestamp\":1619816228000}","apiName":"Ti.Geolocation","bubbleParent":true,"__propertiesDefined__":true},"code":-1,"success":false}
at /ti.geolocation.test.js:610:10
android.emulator.Titanium.Geolocation.methods#forwardGeocoder() works via callback argument (5.0.2)5.039
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:585:32)
android.emulator.Titanium.UI.WebViewprogress event (5.0.2)10.018
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.ipad.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4.0)0.485
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped@2x.png')
    mismatched pixels. allowed: 14840, actual: 53921
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/910FD7BC-F39C-471B-BC49-1EB105797892/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/910FD7BC-F39C-471B-BC49-1EB105797892/mocha.app/ti.ui.tableview.test.js:1811:28
run@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/910FD7BC-F39C-471B-BC49-1EB105797892/mocha.app/ti.main.js:8799:22
processImmediateQueue@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/910FD7BC-F39C-471B-BC49-1EB105797892/mocha.app/ti.main.js:8862:18
drainQueues@file:///Users/build/Library/Developer/CoreSimulator/Devices/86F3F1B4-AE7A-4300-B790-6CC22207BDD2/data/Containers/Bundle/Application/910FD7BC-F39C-471B-BC49-1EB105797892/mocha.app/ti.main.js:8839:52
ios.ipad.Titanium.UI.WebView#findString() #findString with configuration (14.4.0)30
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.ipad.Titanium.UI.WebView#findString() #findString without configuration (14.4.0)29.999
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.ipad.Titanium.UI.WebViewbasic authentication should work properly (14.4.0)29.999
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.ipad.Titanium.UI.WebViewbeforeload (14.4.0)29.999
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.iphone.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4.0)0.846
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped@3x.png')
    mismatched pixels. allowed: 14840, actual: 200203
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/122BF252-6968-48E8-A332-50594D2BF160/data/Containers/Bundle/Application/64208D37-22BF-49A4-91AB-002F792F6D27/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/122BF252-6968-48E8-A332-50594D2BF160/data/Containers/Bundle/Application/64208D37-22BF-49A4-91AB-002F792F6D27/mocha.app/ti.ui.tableview.test.js:1811:28
run@file:///Users/build/Library/Developer/CoreSimulator/Devices/122BF252-6968-48E8-A332-50594D2BF160/data/Containers/Bundle/Application/64208D37-22BF-49A4-91AB-002F792F6D27/mocha.app/ti.main.js:8799:22
processImmediateQueue@file:///Users/build/Library/Developer/CoreSimulator/Devices/122BF252-6968-48E8-A332-50594D2BF160/data/Containers/Bundle/Application/64208D37-22BF-49A4-91AB-002F792F6D27/mocha.app/ti.main.js:8862:18
drainQueues@file:///Users/build/Library/Developer/CoreSimulator/Devices/122BF252-6968-48E8-A332-50594D2BF160/data/Containers/Bundle/Application/64208D37-22BF-49A4-91AB-002F792F6D27/mocha.app/ti.main.js:8839:52
ios.iphone.Titanium.UI.WebViewbasic authentication should work properly (14.4.0)30
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.iphone.Titanium.UI.WebViewbeforeload (14.4.0)29.999
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against 4a06154

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lokeshchdhry
Copy link
Contributor

FR Passed.

@sgtcoolguy sgtcoolguy merged commit 943b42f into tidev:master May 3, 2021
sgtcoolguy pushed a commit that referenced this pull request May 3, 2021
@ewanharris ewanharris removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants