New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android): optimize proxy constructor lookup #12774
Conversation
@@ -70,6 +70,7 @@ void ${className}::bindProxy(Local<Object> exports, Local<Context> context) | |||
moduleInstance.Reset(isolate, instance); | |||
<#else> | |||
exports->Set(context, nameSymbol, constructor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: Can't remove this line as it's necessary for modules
|
@garymathews, this change somehow prevents our "bootstrap.json" from being read on app startup. It happens to both encrypted and unencrypted builds. The following error will be logged, which you can see in Jenkins' output. I'm seeing this error on my end too. |
This causes our "hyperloop-examples" sample app to crash.
|
f77652a
to
3fd2bdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR/FR: Pass
Tested the following:
- kitchensink-v2
- hyperloop-examples
- Building module "ti.map" with this PR and using it in a 10.1.0 and 9.1.0 built app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Pass, in addition to Josh's testing I also tested webpack and liveview usage
GetPropertyNames()
callexports->GetConstructorName()
returns the proxy nameRelated Object.constructor
TEST CASE
JIRA Ticket