Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): date dialog picker not showing initial selection in range of min/max #12787

Merged
merged 1 commit into from May 10, 2021

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28442

Summary:

  • Fixes regression introduced by Titanium 10.0.0's new material date picker dialog.
  • The assigned "value" property should be forced in range of "minDate" and "maxDate" if applied.

Test:

  1. Build and run code attached to TIMOB-28442 on Android.
  2. Verify picker shows 2015/12/31 selected.
  3. Tap on the OK button.
  4. In the log, verify 2015/12/31 was printed.

@jquick-axway jquick-axway added android bug no tests backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels May 7, 2021
@jquick-axway jquick-axway added this to the 10.1.0 milestone May 7, 2021
@build build requested a review from a team May 7, 2021 22:03
@build
Copy link
Contributor

build commented May 7, 2021

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 3 tests have failed There are 3 tests failing and 956 skipped out of 15277 total tests.
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.UI.WebViewbeforeload (14.4.0)30
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.iphone.Titanium.UI.WebViewbeforeload (14.4.0)30
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.macos.Titanium.UI.WebViewbeforeload (10.15.5)30.048
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against 56bb9bb

@lokeshchdhry
Copy link
Contributor

FR Passed.

@sgtcoolguy sgtcoolguy merged commit e77282e into tidev:master May 10, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants