Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): missing support for density units on some properties #12807

Merged
merged 6 commits into from Jun 23, 2021
Merged

fix(ios): missing support for density units on some properties #12807

merged 6 commits into from Jun 23, 2021

Conversation

garymathews
Copy link
Contributor

  • Allow parsing of density units for various properties on iOS
    • View.viewShadowRadius
    • padding properties
    • rect properties
    • shadow properties
    • Point types

JIRA Ticket

@garymathews garymathews added ios bug backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels May 12, 2021
@garymathews garymathews added this to the 10.1.0 milestone May 12, 2021
@build build requested a review from a team May 12, 2021 17:41
@build
Copy link
Contributor

build commented May 12, 2021 •
edited

Fails
🚫 Tests have failed, see below for more information.
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Warnings
⚠️

Commit e7f0c49f4619b10e4e22330bef1fde9b743dd255 has a message "Update iphone/TitaniumKit/TitaniumKit/Sources/API/TiUtils.m

Co-authored-by: Ewan Harris ewanharris93@gmail.com" giving 2 errors:

  • subject may not be empty
  • type may not be empty
Messages
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
📖 ❌ 1 tests have failed There are 1 tests failing and 952 skipped out of 14675 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Network.HTTPClientTLSv3 support (11)0.216
Error: Could not determine TLSv3 support.
at HTTPClient.onerror (/ti.network.httpclient.test.js:758:20)

Generated by 🚫 dangerJS against 648c085

jquick-axway
jquick-axway approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@build build added the docs label May 12, 2021
ewanharris
ewanharris reviewed Jun 17, 2021
View reviewed changes
Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS build looks to be failing because of the suggested change

iphone/TitaniumKit/TitaniumKit/Sources/API/TiUtils.m Outdated Show resolved Hide resolved
@lokeshchdhry
Copy link
Contributor

FR Passed

@ewanharris ewanharris merged commit b72d886 into tidev:master Jun 23, 2021
@build build mentioned this pull request Jun 23, 2021
Merged
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris left review comments

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
bug docs in-qe-testing 🕵 ios needs tests 🚨
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@garymathews @build @lokeshchdhry @ewanharris @jquick-axway