Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): guard access to some toast properties #12815

Merged
merged 2 commits into from May 20, 2021

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented May 14, 2021

JIRA: https://jira.appcelerator.org/browse/TIMOB-28448

Prevents error logs like these that could become more severe in future Android versions:
Screenshot 2021-05-14 at 15 19 21

Test case:

const window = Ti.UI.createWindow();
window.addEventListener('open', () => {
    Ti.UI.createNotification({
        title: 'Hello world',
        duration: Ti.UI.NOTIFICATION_DURATION_SHORT
    }).show();
});
window.open();

@build build added this to the 10.1.0 milestone May 14, 2021
@build build requested a review from a team May 14, 2021 13:51
@build
Copy link
Contributor

build commented May 14, 2021

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 5 tests have failed There are 5 tests failing and 957 skipped out of 15270 total tests.
📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.NavigationWindowbasic open/close navigation (5.0.2)10.006
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.TabGroupadd Map.View to TabGroup (5.0.2)15.034
Error: Timeout of 15000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.View"after all" hook for "rgba fallback" (5.0.2)23.711
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.View"after each" hook for "getOrCreateView() should always return a View" (5.0.2)13.693
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.iphone.Titanium.UI.iOS.CollisionBehavior.exampleworks (14.4.0)15.001
Error: Timeout of 15000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against aafbdbf

test: add test case for notifications

fix(android): fix copy-paste
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@jquick-axway jquick-axway added backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge bug in-qe-testing 🕵 labels May 17, 2021
@lokeshchdhry
Copy link
Contributor

FR Passed.

@sgtcoolguy sgtcoolguy merged commit ad7c267 into tidev:master May 20, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label May 20, 2021
@hansemannn hansemannn deleted the TIMOB-28448 branch October 9, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants