Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): correctly process bootstrap paths #12860

Merged
merged 1 commit into from Jun 1, 2021

Conversation

garymathews
Copy link
Contributor

  • Correctly handle bootstrap.json paths on Windows
TESTCASE
  • Create a Titanium application on Windows
  • Build and run application
  • Application should launch successfully without
Error: Requested module not found: ti.playservices\ti.playservices.bootstrap

JIRA Ticket

@garymathews garymathews added android backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge bug no tests labels Jun 1, 2021
@garymathews garymathews added this to the 10.1.0 milestone Jun 1, 2021
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@build
Copy link
Contributor

build commented Jun 1, 2021

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ❌ 8 tests have failed There are 8 tests failing and 957 skipped out of 15414 total tests.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.Network.HTTPClient#timeoutForResource (14.4.0)0.001
Error: onload shouldn't fire. Resource request timeout should reach before transferring entire resource.
file:///Users/build/Library/Developer/CoreSimulator/Devices/8004FEFB-9C69-45DD-8F64-47B0C61BCF24/data/Containers/Bundle/Application/B9102510-EEE1-443F-8813-AA439010BFF3/mocha.app/ti.network.httpclient.test.js:810:40
ios.ipad.Titanium.Network.HTTPClientresponseHeaders (14.4.0)60
Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.ipad.Titanium.UI.ScrollViewcontentOffset (14.4.0)0.12
Error: Uncaught expected 2.5 to equal 10
ios.iphone.Titanium.UI.ScrollViewcontentOffset (14.4.0)0.113
Error: Uncaught expected 2 to equal 10
ios.macos.Titanium.Filesystem.File#getDirectoryListing() can access resource directory files (10.15.5)2.076
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
run@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12860/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9159:22
processImmediateQueue@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12860/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9222:18
drainQueues@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12860/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9199:52
ios.macos.Titanium.Network.HTTPClient#timeoutForResource (10.15.5)0.002
Error: onload shouldn't fire. Resource request timeout should reach before transferring entire resource.
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12860/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.network.httpclient.test.js:810:40
ios.macos.Titanium.Network.HTTPClientresponseHeaders (10.15.5)60.06
Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.macos.Titanium.UI.ScrollViewcontentOffset (10.15.5)0.207
Error: Uncaught expected 7 to equal 10

Generated by 🚫 dangerJS against b3be1c3

@ewanharris ewanharris merged commit 4e44c39 into tidev:master Jun 1, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants