Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): ProgressBar tintColor/trackTintColor ignored as of 10.0.0 #12878

Merged
merged 2 commits into from Jun 14, 2021

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28485

Test:

  1. Build and run the below on Android.
  2. Verify you see a "green" progress bar filling a "red" background bar.
let timerId = null;
const window = Ti.UI.createWindow();
const progressBar = Ti.UI.createProgressBar({
	tintColor: "green",
	trackTintColor: "red",
	animated: false,
	min: 0,
	max: 100,
	value: 0,
	width: "80%",
});
window.add(progressBar);
window.addEventListener("open", () => {
	timerId = setInterval(() => {
		const value = progressBar.value + 1;
		progressBar.value = (value <= 100) ? value : 0;
		progressBar.message = `Progress at ${progressBar.value}%`;
	}, 50);
});
window.addEventListener("close", () => {
	if (timerId) {
		clearInterval(timerId);
		timerId = null;
	}
});
window.open();

@jquick-axway jquick-axway added android bug no tests backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels Jun 10, 2021
@jquick-axway jquick-axway added this to the 10.1.0 milestone Jun 10, 2021
@build build requested a review from a team June 10, 2021 01:09
@build
Copy link
Contributor

build commented Jun 10, 2021

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 2 tests have failed There are 2 tests failing and 992 skipped out of 18091 total tests.
📖

💾 Here's the generated SDK zipfile.

📖 👍 Hey!, You deleted more code than you added. That's awesome!

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.View"after all" hook for "rgba fallback" (5.0.2)10.498
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.ipad.Titanium.Analytics.properties.optedOut defaults to false (14.4.0)0
Error: expected true to be false
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/0AA5D08D-0328-40AB-B678-5E1B11505DD3/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/0AA5D08D-0328-40AB-B678-5E1B11505DD3/mocha.app/ti.analytics.test.js:46:47
run@file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/0AA5D08D-0328-40AB-B678-5E1B11505DD3/mocha.app/ti.main.js:9159:22
processImmediateQueue@file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/0AA5D08D-0328-40AB-B678-5E1B11505DD3/mocha.app/ti.main.js:9222:18
drainQueues@file:///Users/build/Library/Developer/CoreSimulator/Devices/6D1643D4-462C-49DE-84C1-2FF984AF89B5/data/Containers/Bundle/Application/0AA5D08D-0328-40AB-B678-5E1B11505DD3/mocha.app/ti.main.js:9199:52

Generated by 🚫 dangerJS against bfbf96a

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.

@sgtcoolguy sgtcoolguy merged commit 7cf5209 into tidev:master Jun 14, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants