[TIMOB-7226] Complete Ti.UI.WebView implementation #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,7 +41,8 @@ define("Ti/UI/View", | |||
| l = this.children.length; | |||
| for (; i < l; i++) { | |||
| if (this.children[i] === view) { | |||
| this.children.splice(i, 1); | |||
| l = this.children.splice(i, 1); | |||
| l[0]._setParent(); | |||
There was a problem hiding this comment.
Did you intend for the parent to be set to undefined?
There was a problem hiding this comment.
Yep, when you do a Ti.UI.createView(), the _parent is undefined, so when you remove() a child, it's _parent should be restored to undefined.
There was a problem hiding this comment.
Whoops, didn't see the line skip...thought this was part of _insertAt().
|
Code reviewed and tested. Request accepted. |
nebrius
added a commit
that referenced
this pull request
Jan 27, 2012
[TIMOB-7226] Complete Ti.UI.WebView implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.