Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): add "android:exported" to all activities/services with intent-filters #12881

Merged
merged 2 commits into from Jul 30, 2021

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28475

Summary:

  • Adds android:exported="true/false" to all Titanium activities/services that have intent-filters.
  • Added to Titanium activities without intent-filters in case custom "AndroidManifest.xml" defined by app developer adds an intent-filter to them.
  • Needed due to a breaking-change where apps/libraries targeting Android 12 will have a build failure if activities, receivers, or services with an intent-filter don't define an "android:exported" attribute. Must be explicitly defined.

Test:

  1. Create a "Classic" project with the below "tiapp.xml" setting.
  2. Build and run on Android. (Build failure used to occur when targeting Android 12.)
<ti:app>
	<android>
		<manifest>
			<uses-sdk android:targetSdkVersion="31"/>
		</manifest>
	</android>
</ti:app>

@build
Copy link
Contributor

build commented Jun 11, 2021

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 2 tests have failed There are 2 tests failing and 960 skipped out of 15392 total tests.

Tests:

ClassnameNameTimeError
android.emulator.os#freemem() returns a positive Number (5.0.2)0.006
Error: expected 0 to be above 0
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/os.test.js:93:24)
android.emulator.Titanium.UI.ImageView.image with redirected URL and autorotate set to true (5.0.2)10.293
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against 4009589

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.

@sgtcoolguy sgtcoolguy merged commit 49a9eee into tidev:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants