Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(android): support PendingIntent mutable flags #12890

Merged
merged 5 commits into from Aug 25, 2021

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Jun 14, 2021

  • Implement FLAG_IMMUTABLE and FLAG_MUTABLE
TEST CASE
const win = Ti.UI.createWindow({
    title: 'TIMOB-248476',
    layout: 'vertical'
});
const btn = Ti.UI.createButton({
    title: 'CREATE NOTIFICATION',
    height: 50,
    width: Ti.UI.FILL
});

btn.addEventListener('click', _ => {
    const notification = Ti.Android.createNotification({
        icon: Ti.Android.R.drawable.ic_dialog_info,
        contentTitle: 'Axway',
        contentText: 'Open Axway web-page.'
    });
    const pendingIntent = Ti.Android.createPendingIntent({
        intent: Ti.Android.createIntent({
            action: Ti.Android.ACTION_VIEW,
            data: 'https://www.axway.com'
        })
    });

    notification.addAction(Ti.Android.R.drawable.ic_dialog_email, 'OPEN', pendingIntent);
    Ti.Android.NotificationManager.notify(100, notification);
});

win.add(btn);
win.open();
  • On Android 12, an exception should not occur

JIRA Ticket

@build
Copy link
Contributor

build commented Jun 14, 2021

Fails
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 11285 tests are passing.
(There are 737 skipped tests not included in that total)

Generated by 🚫 dangerJS against e8917cd

@garymathews garymathews changed the title impl(android): support PendingIntent mutable flags impr(android): support PendingIntent mutable flags Jun 14, 2021
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Pass. New flags exist and test code works as expected and throws no errors

@ewanharris ewanharris merged commit 75ce8e4 into tidev:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants