Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): export original native module object #12900

Merged
merged 2 commits into from Jun 22, 2021

Conversation

janvennemann
Copy link
Contributor

@janvennemann janvennemann commented Jun 16, 2021

JIRA: https://jira.appcelerator.org/browse/TIMOB-28491

Optional Description:

Skips creating a wrapper module on iOS to ensure the JavaScriptCore callbacks for a proxy are used to access the native properties.

Test Case

Run the attached test module to easily test the fix. The example app included in the module should log the following, indicating the the native property value was successfully changed:

[INFO]  Initial value: Foo
[INFO]  New value: Bar

proptest.zip

@build
Copy link
Contributor

build commented Jun 16, 2021

Fails
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 12616 tests are passing.
(There are 691 skipped tests not included in that total)

Generated by 🚫 dangerJS against 0f7fdc8

@janvennemann janvennemann added the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Jun 16, 2021
@lokeshchdhry
Copy link
Contributor

FR Passed.

@sgtcoolguy sgtcoolguy merged commit 416aae8 into tidev:master Jun 22, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants