Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): logged theme error in "ti.map" module #12919

Merged
merged 1 commit into from Jun 28, 2021

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28358

Summary:

  • Updated "ti.map" module to 5.3.2.
  • Updated map library dependencies.
  • Fixed error that gets logged the first time a map is shown. (Error is harmless though.)

Test:

  1. Set up a Titanium project to use "ti.map" module version 5.3.2 included with this PR.
  2. Build and run the below code on Android.
  3. Verify the map is displayed fine.
  4. Verify the following error does NOT get logged. (This is the fix.)
    [ERROR] ThemeUtils: View class com.google.maps.android.ui.SquareTextView is an AppCompat widget that can only be used with a Theme.AppCompat theme (or descendant).

app.js

const map = require("ti.map");
const window = Ti.UI.createWindow();
window.add(map.createView({
	width: Ti.UI.FILL,
	height: Ti.UI.FILL,
}));
window.open();

@jquick-axway jquick-axway added android bug no tests backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels Jun 24, 2021
@jquick-axway jquick-axway added this to the 10.1.0 milestone Jun 24, 2021
@build
Copy link
Contributor

build commented Jun 24, 2021

Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 16426 tests are passing.
(There are 982 skipped tests not included in that total)

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS against 4fe0515

@lokeshchdhry
Copy link
Contributor

FR Passed.

@sgtcoolguy sgtcoolguy merged commit 746f251 into tidev:master Jun 28, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants