New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): hierarchy error when using SplitWindow and NavigationWindow #12930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes TIMOB-28497
Tests:
|
garymathews
approved these changes
Jun 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
garymathews
added
in-qe-testing 🕵
backport 10_2_X
when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge
labels
Jun 29, 2021
jquick-axway
removed
the
backport 10_2_X
when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge
label
Jun 29, 2021
FR Passed. |
jquick-axway
added
the
backport 10_2_X
when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge
label
Jul 19, 2021
build
removed
the
backport 10_2_X
when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge
label
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28497
Summary:
SplitWindow
and aNavigationWindow
at the same time.NavigationWindow
wrongly using root application controller instead of the 1sts controller available in the view hierarchy.Test:
ListView
on the left side with a title "Master View" above it.