Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): crash with MapView in TabGroup as of 10.0.1 #12932

Merged
merged 1 commit into from Jul 13, 2021

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28501

Summary:

  • Regression caused by PR fix(android): improve ListView scroll performance #12909 in Titanium 10.0.1 and was caught before release.
  • Crash occurs because map's activity is wrongly changed to previous window's activity (or splash).
    • Issue was with parent tab proxy whose activity was never updated to use TabGroup's activity.

Test:

  1. Set up a project with the "ti.map" module.
  2. Build and run the below on Android.
  3. Verify a map is displayed within tab 1.
  4. Verify you can select tab 2 and 3.
const map = require("ti.map");
const tabWindow1 = Ti.UI.createWindow();
tabWindow1.add(map.createView({
	width: Ti.UI.FILL,
	height: Ti.UI.FILL,
}));
const tabWindow2 = Ti.UI.createWindow();
tabWindow2.add(Ti.UI.createLabel({ text: "Tab 2" }));
const tabWindow3 = Ti.UI.createWindow();
tabWindow3.add(Ti.UI.createLabel({ text: "Tab 3" }));
const tabGroup = Ti.UI.createTabGroup({
	tabs: [
		Ti.UI.createTab({ title: "Tab 1", window: tabWindow1 }),
		Ti.UI.createTab({ title: "Tab 2", window: tabWindow2 }),
		Ti.UI.createTab({ title: "Tab 3", window: tabWindow3 }),
	],
});
tabGroup.open();

@jquick-axway jquick-axway added android bug no tests backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels Jul 2, 2021
@jquick-axway jquick-axway added this to the 10.1.0 milestone Jul 2, 2021
@build build requested a review from a team July 2, 2021 01:34
@build
Copy link
Contributor

build commented Jul 2, 2021

Fails
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 11148 tests are passing.
(There are 681 skipped tests not included in that total)

Generated by 🚫 dangerJS against 69aebec

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.
App does not crash anymore.

@sgtcoolguy sgtcoolguy merged commit 535430c into tidev:master Jul 13, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants