Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): compile with API Level 31 #12959

Merged
merged 5 commits into from Aug 2, 2021

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Jul 16, 2021

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28471

Summary:

  • Compiles against API Level 31 (aka: Android 12).
  • Does not "target" API Level 31 yet until all breaking-changes have been resolved.
    • Will update "package.json" file's "andoid sdk" to target 31.x in a future PR.

@build
Copy link
Contributor

build commented Jul 16, 2021

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 2 tests have failed There are 2 tests failing and 1028 skipped out of 17026 total tests.
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Geolocation.methods#forwardGeocoder() works via callback argument (5.0.2)5.045
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:585:32)
android.emulator.Titanium.UI.NavigationWindowbasic open/close navigation (5.0.2)10.022
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against b8d4b6c

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not using for unit tests yet to try and understand what the breakage will be
@lokeshchdhry
Copy link
Contributor

FR Passed.
Compiling with API 31 looks good. Checked with KS V2 on Android 10 & Android 7.1.1.

@sgtcoolguy sgtcoolguy merged commit 269b397 into tidev:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants