Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): rare random crashes on 64-bit devices #12987

Merged
merged 4 commits into from Aug 31, 2021
Merged

fix(ios): rare random crashes on 64-bit devices #12987

merged 4 commits into from Aug 31, 2021

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-27875

Summary:

  • Fixes issue where JS property name generation for storing native objects can have name collision on 64-bit systems.
  • Code was wrongly casting a 64-bit pointer to a 32-bit integer and trying to generate a unique property name from it.

@jquick-axway jquick-axway added this to the 10.1.0 milestone Jul 29, 2021
@build build requested a review from a team July 29, 2021 05:40
@build
Copy link
Contributor

build commented Jul 29, 2021 •
edited

Fails
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 3325 tests are passing.
(There are 223 skipped tests not included in that total)

Generated by 🚫 dangerJS against 781f2db

garymathews
garymathews approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@hansemannn
Copy link
Collaborator

@jquick-axway Can you maybe include the changes from @garymathews as well? Then we could cherry-pick these into 10_0_X already and go with it :-)

@hansemannn
Copy link
Collaborator

We use this in production since a few weeks now and it feels stable. So it'd be great to see it merged!

@ewanharris ewanharris merged commit 054c3dc into tidev:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

@janvennemann janvennemann Awaiting requested review from janvennemann

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jquick-axway @build @hansemannn @garymathews @ewanharris