Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): properly map user activity for cold starts #12988

Merged
merged 2 commits into from Aug 5, 2021

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Jul 29, 2021

JIRA:

Note:
Also fixes #12944

Summary:
The reason is that on a cold start, the user activity contains some native values that cannot be bridged into an NSDictionary by default. Just like for other instances (like CLLocation or UIShortcutItem), we should bridge it to JS-accessible types.

@build
Copy link
Contributor

build commented Jul 29, 2021

Fails
🚫 Tests have failed, see below for more information.
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 3 tests have failed There are 3 tests failing and 960 skipped out of 15399 total tests.
📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Network.HTTPClientresponseXML (5.0.2)5.645
Error: expected true to be false
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at HTTPClient.xhr.onload (/ti.network.httpclient.test.js:28:40)
ios.macos.Titanium.Blobimage dimensions should be reported in pixels (10.15.5)0.07
Error: expected 6 to be 11
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12988/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12988/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.blob.test.js:488:33
ios.macos.Titanium.Media.properties.audioPlaying is a Boolean (10.15.5)9.685
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
run@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12988/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9258:22
processImmediateQueue@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12988/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9321:18
drainQueues@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12988/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9298:52

Generated by 🚫 dangerJS against 82a5d8e

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jquick-axway jquick-axway added in-qe-testing 🕵 backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels Jul 29, 2021
Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR pass. When calling Ti.App.arguments/Ti.App.getArguments after the app has cold launched via a Universal Link there is no longer a crash

@ewanharris ewanharris merged commit 3c8ee0b into tidev:master Aug 5, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes on cold launch with Ti.App.getArguments() if opened from App Clip
4 participants