New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): properly map user activity for cold starts #12988
Conversation
Tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2abc242
to
82a5d8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR pass. When calling Ti.App.arguments/Ti.App.getArguments after the app has cold launched via a Universal Link there is no longer a crash
JIRA:
Note:
Also fixes #12944
Summary:
The reason is that on a cold start, the user activity contains some native values that cannot be bridged into an
NSDictionary
by default. Just like for other instances (likeCLLocation
orUIShortcutItem
), we should bridge it to JS-accessible types.