Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): views added to ScrollableView can be lost upon window open #12989

Merged
merged 2 commits into from Aug 5, 2021
Merged

fix(android): views added to ScrollableView can be lost upon window open #12989

merged 2 commits into from Aug 5, 2021

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28503

Summary:

  • Views added to ScrollableView after creation, but before its window has been opened, can be all be lost.
  • Issue is "views" property is null/empty and the TiUIScrollableView.processProperties() method ended up clearing all views that were added via the ScrollableViewProxy class' setViews() and addView() methods.
  • This is a regression as of Titanium 10.0.1.

@jquick-axway jquick-axway added android bug no tests backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels Jul 30, 2021
@jquick-axway jquick-axway added this to the 10.1.0 milestone Jul 30, 2021
@build build requested a review from a team July 30, 2021 05:56
@build
Copy link
Contributor

build commented Jul 30, 2021 •
edited

Fails
🚫 Tests have failed, see below for more information.
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 697 skipped out of 13249 total tests.
📖 👍 Hey!, You deleted more code than you added. That's awesome!

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Network.HTTPClientresponseXML (5.0.2)1.073
Error: expected true to be false
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at HTTPClient.xhr.onload (/ti.network.httpclient.test.js:28:40)

Generated by 🚫 dangerJS against e9e2f6d

garymathews
garymathews approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

ewanharris
ewanharris approved these changes Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR pass. Views added to a ScrollableView after creation but before Window open are now visible (test code in ticket)

@ewanharris ewanharris merged commit 04f8d8e into tidev:master Aug 5, 2021
@build build mentioned this pull request Aug 5, 2021
Merged
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jquick-axway @build @garymathews @ewanharris