fix(android): restore "res/drawable" support to Ti.UI.Button images #13148

jquick-axway · 2021-10-27T21:29:10Z

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28558

Summary:

The changes I made in PR feat: add "imageIsMask" property to Ti.UI.Button #13125 caused a regression where Ti.UI.Button image won't load from "res/drawable" DPI scaled images anymore. We need to restore this behavior.
This issue was caught before release.

Test:

Download kitchensink-v2 app: chore: update for Titanium SDK 10.1.0 kitchensink-v2#59
Tap on the "Button" list item.
Verify the "Image Button" icon is the same size as shown in the PR's screenshot, except the icon should be "white" when using the Light theme.

Fixes TIMOB-28558

build · 2021-10-27T21:49:30Z

	Messages
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖	✅ All tests are passing Nice one! All 19585 tests are passing. (There are 1157 skipped tests not included in that total)
📖	💾 Here's the generated SDK zipfile.
📖	👍 Hey!, You deleted more code than you added. That's awesome!

Generated by 🚫 dangerJS against c9891ee

garymathews

CR: PASS
FT: PASS

fix(android): restore res/drawable support for Ti.UI.Button

1c11fd6

Fixes TIMOB-28558

jquick-axway added android bug no tests labels Oct 27, 2021

jquick-axway requested a review from garymathews October 27, 2021 21:29

build added this to the 10.2.0 milestone Oct 27, 2021

build requested a review from a team October 27, 2021 21:49

garymathews approved these changes Oct 28, 2021

View reviewed changes

Merge branch 'master' into TIMOB-28558-rev1

c9891ee

build added the in-qe-testing 🕵 label Oct 28, 2021

jquick-axway merged commit 11dc187 into tidev:master Oct 28, 2021

Provide feedback