timob-7240: remove children of tabgroup properly #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -198,7 +198,6 @@ protected void onResume() | |||
| @Override | |||
| protected void onDestroy() | |||
| { | |||
| TiApplication.removeFromActivityStack(this); | |||
There was a problem hiding this comment.
Why not also do this? (removeFromActivityStack)
There was a problem hiding this comment.
This is done in TabGroupProxy.handleClose().
There was a problem hiding this comment.
New PR 1369 opened to put this line back in
|
FR works (was able to recreate failcase in 1.8.1, then it worked fine in this branch.) I'll wait for a resp. to the one comment before accepting. |
|
CR accepted |
billdawson
added a commit
that referenced
this pull request
Feb 6, 2012
timob-7240: remove children of tabgroup properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: http://jira.appcelerator.org/browse/TIMOB-7240
Testing steps in JIRA