[TIMOB-7196] Completed implementation of Ti.UI.EmailDialog. Fixed small ... #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll bug with lang.urlEncode() that also affected Ti.Network.HttpClient. Also added Ti+ modules to cached builds and added better compile time display.
|
Code reviewed and tested. Request accepted. |
| @@ -24,6 +26,7 @@ methods: | |||
| events: | |||
| - name: complete | |||
| summary: fired when the email dialog has completed sending the email | |||
| description: On Mobile Web, `complete` fires immediately after calling open() and will always succeed. | |||
There was a problem hiding this comment.
It's not quite right to say that the event succeeds, but I can't think of better wording offhand. Maybe something like:
On Mobile Web, the platform cannot determine if the message was sent or not. The complete call fires immediately after calling open(),
and always reports success.
|
Reviewed docs. 1 niggle, take it or leave it. approved In the future, I recommend wrapping YAML docs to 100 characters--they're a lot easier to review in github. |
|
Fixed verbiage as Arthur's was better than mine. |
cb1kenobi
added a commit
that referenced
this pull request
Feb 10, 2012
[TIMOB-7196] Completed implementation of Ti.UI.EmailDialog. Fixed small ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...bug with lang.urlEncode() that also affected Ti.Network.HttpClient. Also added Ti+ modules to cached builds and added better compile time display.