Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-6038] Expose tiapp.xml Props to App Properties #1395

Merged
merged 1 commit into from Feb 15, 2012
Merged

[TIMOB-6038] Expose tiapp.xml Props to App Properties #1395

merged 1 commit into from Feb 15, 2012

Conversation

dawsontoth
Copy link
Contributor

Mix in the values from the tiapp.xml in to the App properties in addition to System properties. This is redundant, I know, but it touches the least amount of code.

Mix in the values from the tiapp.xml in to the App properties in addition to System properties. This is redundant, I know, but it touches the least amount of code.
@dawsontoth
Copy link
Contributor Author

This gives API parity, but with a couple complications:

  • tiapp.xml properties would overwrite existing properties.
  • removing a property from tiapp.xml wouldn't remove the last set value in shared preferences.

@rusticphilosopher
Copy link
Contributor

Noting comment left on Jira ticket for visibility:

"Reference info regarding Android implementation: I don't know why we even store the tiapp.xml properties inside the "systemProperties" map on Android. We should totally remove the systemProperties array and work solely with the appProperties map since all the documentation works off this assumption. If anyone has an objection to this, please comment.

Ideally, the generated App.java file would ONLY insert properties into a single properties map. For the time being, this pending fix will be accepted but we should implement a real fix at the platform level to remove the duplicate properties map."

@rusticphilosopher
Copy link
Contributor

Code reviewed and functional test passed on Rhino and V8. Accepted

rusticphilosopher pushed a commit that referenced this pull request Feb 15, 2012
[TIMOB-6038] Expose tiapp.xml Props to App Properties
@rusticphilosopher rusticphilosopher merged commit 818442c into tidev:master Feb 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants