[TIMOB-7581] Fixed bug with how the loader processes plugins. Almost mov... #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moved isDef() out of loader to lang. Minor code cleanup.
|
One comment: it seems counter intuitive to have require.is and lang.isDef. They should both be in the same namespace since they are very closely related. |
|
is() will eventually get moved into lang along with each, has, mix, and on. The Ti package should not have dependencies on anything in the loader. However, we'll have a has() shim and shims for all these other methods that will get ripped out by the AST. That's why I only moved isDef() right now since it's not used by the loader at all. |
|
Code reviewed and tested. Request accepted. |
nebrius
added a commit
that referenced
this pull request
Feb 13, 2012
[TIMOB-7581] Fixed bug with how the loader processes plugins. Almost mov...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ed isDef() out of loader to lang. Minor code cleanup.