Timob 3800 socket tcp timeout for accept iphone #1425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 16, 2012 01:45
…after 5000 seconds, not 5 second. After this modification, it only just wait 5 seconds.
…timeout = 5
000; socket.accept();, then it wait 5 seconds for incomming connection.
It will explicitly distinct with socket.accept({timeout: 5000}).
|
sakisakira - please file a JIRA ticket with a valid test case as per the pull request guidelines before we can process this PR. |
|
Signed CLA is in place. |
|
@sakisakira Thanks for this and #1426, we've done some talking today and realize we need to allow for more granular timeout control in more situations in our Socket.TCP API. I've opened a new ticket here that you can track: Since this will require more API changes, I am closing this PR and #1426, and we will tackle these new APIs for 2.1. If you'd like to be involved in the discussion, feel free to drop by #titanium_dev on irc.freenode.net and poke me (marshall_law) , Opie (dizymonkee), or Stephen (stramer) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can use timeout option for accept, like, socket.listen(); socket.timeout = 5
000; socket.accept();, then it wait 5 seconds for incomming connection.
It will explicitly distinct with socket.accept({timeout: 5000}).