iOS: Socket.TCP connect() wait too long when timeout set #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after 5000 seconds, not 5 second. After this modification, it only just wait 5 seconds.
|
sakisakira - please file a JIRA ticket with a valid test case as per the pull request guidelines before we can process this PR. |
|
Signed CLA is in place. |
1 similar comment
|
Signed CLA is in place. |
|
@sakisakira We will need you to open a JIRA issue and test case to proceed with this pull request (see my instructions from your previous PR :) |
|
l posted TC-684. Would you tell me what should I do to post it to TIMOB JIRA? |
|
I have moved this ticket to TiMOB. https://jira.appcelerator.org/browse/TIMOB-8014 |
|
@sakisakira Thanks! We'll try to get this reviewed ASAP |
|
Code reviewed. APPROVED. |
|
Functional tested, iPhone Sim 5.0. APPROVED. |
sptramer
pushed a commit
that referenced
this pull request
Mar 16, 2012
…aitTooLong [TIMOB-8014] iOS: Socket.TCP connect() wait too long when timeout set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If socket.timeout = 5000; socket.connet();, then it does not timeout after 5000 seconds, not 5 second. After this modification, it just wait 5 seconds.