Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-7694 Null check on table view's native listView before accessing. #1451

Merged
merged 1 commit into from Feb 17, 2012
Merged

TIMOB-7694 Null check on table view's native listView before accessing. #1451

merged 1 commit into from Feb 17, 2012

Conversation

billdawson
Copy link
Contributor

@hieupham007
Copy link
Contributor

Code reviewed and tested with 3.0 Galaxy Tab 10.1 and 2.3.3 DroidX. On Rhino, 2.3.3 device (DroidX), if you click very fast, after 1-2 cycles, then you won't be able to close window 2. It says: unable to close, window is not open, even though it is open.

@rusticphilosopher
Copy link
Contributor

Code reviewed and Accepted

Hieu, do we know if this is a regression introduced with this fix or existing behavior? I suspect that is a separate issue that does not need to hold up the acceptance of this PR. Please advise.

@hieupham007
Copy link
Contributor

That I'm not sure, this could indicate a deeper issue (we won't know until further investigation). In other words, this fix is just a band-aid. It's up to you and Bill.

@rusticphilosopher
Copy link
Contributor

Hieu, Can you reproduce the behavior with the same test case on master?

@marshall
Copy link
Contributor

@hieupham007 @DizzyMonkey @billdawson I was able to confirm the error that Hieu saw on my Galaxy Nexus, but this appears to be a completely unrelated issue that's related to timing and the internal window states in window.js

Other than that, I'm fine with merging this as is.

I've created a new bug for the behavior Hieu found here:
https://jira.appcelerator.org/browse/TIMOB-7705

@hieupham007 Can you test this against 1.8.0.1 and make sure this isn't a regression?

@marshall
Copy link
Contributor

Functional review accepted, tested on both V8 and Rhino

marshall added a commit that referenced this pull request Feb 17, 2012
TIMOB-7694 Null check on table view's native listView before accessing.
@marshall marshall merged commit 81f8c8d into tidev:master Feb 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants