[TIMOB-7681] Preserve remote hires when caching + local file load fixes #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2012 13:38
- Fixes to '@2x' caching for remote hires for non-retina devices
| } | ||
| } | ||
| else if ([arg isKindOfClass:[NSString class]]) { | ||
| } |
There was a problem hiding this comment.
why do you have this empty else-if statement ?
There was a problem hiding this comment.
Vestigial problem from a different attempt at the fix, will remove
|
Code looks good. Please address comment. |
|
Code reviewed. APPROVED |
mstepanov
pushed a commit
that referenced
this pull request
Feb 24, 2012
[TIMOB-7681] Preserve remote hires when caching + local file load fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix should be regressed against TIMOB-7051. The most significant changes here are to loading resources from the filesystem directly (which now correctly displays the "default" image if a file doesn't load) and the
@2xcaching. This means that testers should: