[TIMOB-6463] Protect/unprotect keyboard toolbar items #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 24, 2012 13:14
- Numerous TODOs added regarding memory management (outside scope of this PR)
|
Code reviewed. APPROVED |
|
Functional test PASSED. Tested TIMOB-6463 on iPhone 5.0.1, iPhoneSim 4.3/5.0 |
mstepanov
pushed a commit
that referenced
this pull request
Feb 28, 2012
[TIMOB-6463] Protect/unprotect keyboard toolbar items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix properly memory-manages the keyboard toolbar items constants for text fields.
Note that there are numerous
TODOs added to the source regarding the inadequacy of our current memory management infrastructure and how it relates to timing and the "discovery" of proxy objects. I will likely file some TIMOB bugs related to them.