[TIMOB-7674] iOS: CFBundleShortVersionString now updated in Info.plist #1516
Conversation
|
@sfeather We require that you sign the CLA before we can accept any contributions: http://appc.me/cla |
|
I signed one a week ago. Well, on the 21st of February. |
| CFBundleShortVersionString = self.properties['version'] | ||
| app_version_ = CFBundleShortVersionString.split('.') | ||
| if(len(app_version_) > 3): | ||
| CFBundleShortVersionString = app_version_[0]+app_version_[1]+app_version_[2] |
There was a problem hiding this comment.
Should be ..
CFBundleShortVersionString = app_version_[0]+'.'+app_version_[1]+'.'+app_version_[2]
|
Please address the comment above, everything else seems fine. |
|
code reviewed and APPROVED |
|
Pull Accepted Tested with the following scenarios
|
|
@sfeather : Thank you for raising the ticket and working on the fix for it. We deeply appreciate the effort you have put forward to resolving this issue and hope to see more from you. |
[TIMOB-7674] iOS: CFBundleShortVersionString now updated in Info.plist
|
srahim, I think I may need to add a change to make this complete based upon this (https://jira.appcelerator.org/browse/TIMOB-7931?focusedCommentId=185698#comment-185698) ticket Need to make sure that the default template for the plist has a CFBundleShortVersionString entry to modify. Will take a look at it in the morning. |
The Info.plist for ios builds was never being updated with CFBundleShortVersionString so in all build types (simulator, device, distribution) CFBundleShortVersionString = 1.0
Reference https://jira.appcelerator.org/browse/TIMOB-7674 for background.
The formatting of CFBundleShortVersionString reflects decisions made on Pull 889 (#889)