TIMOB-7233: Android: evalJS and evalFile methods deprecated in TiContext #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrollRuntime, and re-add backwards compatibility into TiContext for evalJS and evalFile. TIMOB-7233
| import org.appcelerator.kroll.common.Log; | ||
| import org.appcelerator.kroll.common.TiConfig; | ||
| import org.appcelerator.kroll.util.KrollAssetHelper; | ||
| import org.appcelerator.kroll.util.KrollStreamHelper; |
|
Code reviewed. Request accepted |
TiContext. TIMOB-7233
|
Code reviewed and functionally tested. Request Accepted |
|
Putting merge on hold for further testing |
|
Looks like we are good to merge this now |
ayeung
pushed a commit
that referenced
this pull request
Mar 5, 2012
TIMOB-7233: Android: evalJS and evalFile methods deprecated in TiContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.appcelerator.org/browse/TIMOB-7233
See testing instructions in my comment:
https://jira.appcelerator.org/browse/TIMOB-7233?focusedCommentId=184637&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-184637