[TIMOB-7866] Don't Release At Completion #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Releasing the movie at completion means that we will no longer be able to programmatically control it (for example, the "stop" method won't have a reference to the movie). The movie will be released when the proxy is destroyed.
|
I could have sworn there was an issue with not releasing the video at that point, but I was unable to find a JIRA about it, and memory allocations show the movies are properly released. Code and Functional --actually, going to try one last test. |
|
Code ACCEPTED. Functional PASSED. Pushing BUTTON. |
WhichKatieDid
added a commit
that referenced
this pull request
Mar 6, 2012
[TIMOB-7866] Don't Release At Completion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing the movie at completion means that we will no longer be able to programmatically control it (for example, the "stop" method won't have a reference to the movie).
The movie will be released when the proxy is destroyed.