TIMOB-7843 Detect android bug 2373 in Android 3.0+ as well (previously o... #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y our check worked only for < 3.0)
|
Tested on Kindle Fire, the problem still persists. |
|
Please test an Android 3.0+ non-Kindle device too. (It's not mentioned in the title, but in the description of the JIRA.) I don't have a Kindle, so we need to at least make sure it works on non-Kindles. |
… timob-7843 Conflicts: android/titanium/src/java/org/appcelerator/titanium/TiLaunchActivity.java
|
I tested with G-Slate running 3.1, btw. I believe QE has one. It would be great if you could test with that so we're apples-to-apples. |
|
Confirmed that this is fixed for 3.x. Tested with Galaxy Tab 10.1 and it was able to reproduce the fail case. Re-tested with Kindle Fire, the problem stil persists. |
|
Since this has been confirmed for 3.x devices, I am merging Bill's fix here but keeping the issue open as Allen is taking over the Kindle Fire portion of the issue |
marshall
added a commit
that referenced
this pull request
Mar 10, 2012
TIMOB-7843 Detect android bug 2373 in Android 3.0+ as well (previously o...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ur check worked only for < 3.0)
https://jira.appcelerator.org/browse/TIMOB-7843
Test is the fail case in the ticket.