Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-7931] Custom Info.plist files without CFBundleShortVersionString throw an exception #1623

Closed
wants to merge 1 commit into from

Conversation

stephenfeather
Copy link
Contributor

Code change grabs the exception generated in TiApp.py if CFBundleShortVersionString is missing from a custom Info.plist and hands the user a friendly reminder via a console [WARN] that their custom Info.plist file needs to be updated.

While the original [TIMOB-7931] specifically addressed KitchenSink build problems, this code will help move users with projects built against older TiMobile sdks towards the current Apple submission requirements.

To test, use the current kitchen sink project.

Build using current code base and an exception is thrown in tiapp.py because the CFBundleShortVersion key does not exist in the custom Info.plist file from the {project} directory.

Add the key as listed in [TIMOB-7931] to the Info.plist and the build completes as expected.

Note: By grabbing and handling the exception, this code allows the build to continue. We could force the key to be added to the generated Info.plist but I feel that the user needs to update their original Info.plist without the build tools interference.

@srahim
Copy link
Contributor

srahim commented Mar 9, 2012

@sfeather Thank you for working on this bug with us. Though your fix catch's the custom info.plist case, just printing out an error and carrying on with the build would not be a optimal solution, since it is something that we can always generate ourselves. So i have made PR for addressing this in PR #1627.

@srahim srahim closed this Mar 9, 2012
@stephenfeather
Copy link
Contributor Author

No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants