New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timob-7932: Android: drillbit failure for Android test suite #1628
Conversation
Review in progress... |
@@ -28,6 +28,7 @@ describe("Ti.Android tests", { | |||
Ti.API.debug(JSON.stringify(e)); | |||
valueOf(e.resultCode).shouldBe(Ti.Android.RESULT_OK); | |||
})); | |||
callback.passed(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't correct since it will force the test to pass before the async callback runs.
You don't need to call callback.complete() when using this.async()..
With out this patch the test is failing for me because e.resultCode is undefined. Device: Xoom (Android 4.0.3) |
Updated. Please review. |
Tested on device (HTC Desire, Android 2.2). All tests passed, no crashes. |
Functional tested and code reviewed. Accepted |
timob-7932: Android: drillbit failure for Android test suite
https://jira.appcelerator.org/browse/TIMOB-7932