Timob 8019 Modal bug fix. #1685
Conversation
…ways and broke windows underneath.
|
Good catch! Actually, we don't even need to define open() or close() at all in the Window anymore. :) |
|
Funny you mention that, I was just coming here to note that before you closed it. I think I want to redo this one a bit though and reintroduce modal support by doing a "dimmed" view (like OptionDialog), so let's hold off on this PR until later. |
|
|
||
| Mobile Web note: All windows are modal from a behavioral standpoint, and all windows can | ||
| be translucent or opaque based on the value of `backgroundColor`. Setting the modal value | ||
| applies a visual style that is similar to iOS, if the window itself has a height and width |
There was a problem hiding this comment.
What visual style does iOS use? Does this refer to adding a nav bar? Dimming the background?
Something like this might be clearer:
On Mobile Web, windows are always modal, blocking input to underlying windows. If the window does not occupy the full
screen, setting modal to true provides a visual cue by dimming any background windows. If the window occupies the full
screen, modal has no effect.
On Mobile Web and iOS, the modal property has no effect on whether the window is translucent or opaque.
|
Doc reviewed, suggested rewording. |
| if (value !== oldValue) { | ||
| if (value) { | ||
| var parentContainer = this._modalParentContainer = UI.createView(); | ||
| parentContainer.add(this._modalDimmer = UI.createView({ |
There was a problem hiding this comment.
No sense setting this._modalDimmer if it's not used.
|
Code reviewed and tested. Request accepted. |
|
Accepted! |
No description provided.