[TIMOB-8008] Fixed issues with base64 encodings. Added implementation for sha1 #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,6 +9,10 @@ since: "0.9" | |||
| methods: | |||
| - name: base64decode | |||
| summary: Returns the specified data decoded from Base64. | |||
| description: | | |||
There was a problem hiding this comment.
How can you tell if the Blob has binary data vs. base64 encoded data (which in practice would be base64 encoded twice)?
There was a problem hiding this comment.
If the mime type is application/, image/, video/, or audio/, it's binary. I track it with the _isBinary flag.
|
Code reviewed and tested. Request approved. |
nebrius
added a commit
that referenced
this pull request
Mar 18, 2012
[TIMOB-8008] Fixed issues with base64 encodings. Added implementation for sha1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.