Timob 6586 add support for backgroundRepeat property that will allow tiling of background image #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 20, 2012 18:31
…l cause backgroundImage to be tiled
|
CR + FR in progress |
| } | ||
|
|
||
| } catch (IOException e) { | ||
| Log.e(LCAT, "Exception occured when trying to open stream to specified background image: ", e); |
There was a problem hiding this comment.
This log is sort of confusing. Rephrase perhaps?
There was a problem hiding this comment.
Nvm. Re-read it, and it makes sense now :)
|
Functional test failed. Crash log when launching KS: http://pastie.org/private/pzxzzfbx2f7of5yi3izzg |
|
Tested with test case in v8/rhino, ran KS UI tests in v8/rhino, did drillbit on v8/rhino. Request accepted. |
marshall
added a commit
that referenced
this pull request
Mar 21, 2012
Timob 6586 add support for backgroundRepeat property that will allow tiling of background image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-6586
Test case attached to ticket. Given the changes made, a pass of the drillbit UI tests and the KS UI tests should be run against both runtimes in addition to the actual test case in ticket.