Timob 8116 minRowHeight and maxRowHeight. #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return value; | ||
| }, | ||
| value: "100%" | ||
| } |
There was a problem hiding this comment.
This PR looks good, though I'd like to clean up these properties by:
// at the top
var postRefresh = function() {
this._refreshSections();
};
Then in each prop, just set:
maxRowHeight: {
post: postRefresh
}
Because the post function (as well as set/get) are internally apply()'d internally (thanks to mixProps()), you can use "this" in a function at the top.
|
Code reviewed and tested. Request accepted. |
cb1kenobi
added a commit
that referenced
this pull request
Mar 21, 2012
Timob 8116 minRowHeight and maxRowHeight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.