[TIMOB-7145] Fixed some bugs in VideoPlayer. Added fullscreen support for Firefox #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Firefox. [TIMOB-8041] Fixed maxlength of textfields.
| @@ -602,7 +602,11 @@ properties: | |||
| summary: URL of the media to play. | |||
| description: | | |||
| URL identifying a local or remote video to play. | |||
| type: String | |||
|
|
|||
| On Mobile Web, video format support depends on the web browser. You can specify an | |||
There was a problem hiding this comment.
Would it be worth mentioning that there isn't a common format across all browsers, and that specifying an array is necessary in practice?
There was a problem hiding this comment.
It's sort of implied by saying the supported video formats depend on the browser. FWIW, Arthur helped me write that sentence, so he has effectively signed off on it. Unless you feel strongly that it needs clarification, Arthur and I are cool with it.
There was a problem hiding this comment.
No strong feelings either way...sounds good to me.
|
Code reviewed and tested. Request approved. |
nebrius
added a commit
that referenced
this pull request
Mar 22, 2012
[TIMOB-7145] Fixed some bugs in VideoPlayer. Added fullscreen support for Firefox
|
That's strange, the above comment did not render correctly. |
|
Resolved validation failure here #1742 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes:
[TIMOB-8041] Fixed maxlength of textfields.